[ENG-10042] fix(registry): moderators cannot approve registration updates#887
Open
Vlad0n20 wants to merge 1 commit intoCenterForOpenScience:feature/pbs-26-2from
Open
[ENG-10042] fix(registry): moderators cannot approve registration updates#887Vlad0n20 wants to merge 1 commit intoCenterForOpenScience:feature/pbs-26-2from
Vlad0n20 wants to merge 1 commit intoCenterForOpenScience:feature/pbs-26-2from
Conversation
Vlad0n20
force-pushed
the
fix/ENG-10042
branch
from
9c88cba to
805bdcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix an issue where moderators could not approve registration updates
because the mapper was selecting the wrong schema response (first one
instead of the one with
pending_moderationstate), and the UI didnot properly handle revisions awaiting admin approval.
Summary of Changes
Screenshot(s)
Side Effects
None expected. Changes are scoped to the moderation/registry decision flow.
QA Notes